Fix remaining problems with version display #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waxlamp
force-pushed
the
netlify-build-improvement
branch
from
eda72a8
to
9e21c1b
Compare
waxlamp
changed the title
waxlamp
force-pushed
the
netlify-build-improvement
branch
from
9e21c1b
to
063e2cd
Compare
mvandenburgh
approved these changes
Feb 7, 2024
waxlamp
added
patch
|
🚀 PR was released in |
|
woohoo -- it worked! thanks @waxlamp ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
git fetch --tagscommand to the Netlify build command to ensure that the build process picks up on recently published tags (rather than just a pull on the trigger branch that seems to be happening now). Since git tags are not normally part of most Netflify builds, this would explain why we're always "behind" when displaying the tag versions in the app.We'll know if this works after the PR is published with release tags. If it doesn't, we can revert this change and look for a different solution.
Closes #1089.